Fix flag-register read in fiber-savecontext on arm64#84
Merged
Conversation
int() rejects TYPE_CODE_FLAGS registers (eflags/pstate), and the (unsigned long) C-cast fallback coerces eflags on x86 but raises "Invalid cast" for arm64 pstate. That throw escapes fiber-savecontext and aborts the entire crash-dump before any fiber backtrace prints. Read the raw register bytes instead - no cast for gdb to reject, works on both arches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
int() rejects TYPE_CODE_FLAGS registers (eflags/pstate), and the (unsigned long) C-cast fallback coerces eflags on x86 but raises "Invalid cast" for arm64 pstate. That throw escapes fiber-savecontext and aborts the entire crash-dump before any fiber backtrace prints. Read the raw register bytes instead - no cast for gdb to reject, works on both arches.